Ticket #10402 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

Flash CNXML tag corrupts flash-vars attribute

Reported by: Joe Berkovitz <joe@…> Owned by: maxwell
Priority: unprioritized Milestone: Hot Fixes
Component: Unknown Version: Live
Severity: severe Keywords: ReportABug
Cc: System Area: Content Display
Primary Skill: Unspecified
Site URL: http://cnx.org/content/m34270/latest/
Suppress email to reporter: no

Description (last modified by ew2) (diff)

The <flash> tag does not work properly: it corrupts the FlashVars? parameter as packaged in the <object> tag within the HTML page output after translation.

The flash-vars attribute is supposed to pass its value through to a <param name="FlashVars?" value="..."> tag in the output. However, what occurs in the page source is this:

<param name="FlashVars?" value="@flash-vars"/>

Note that the FlashVars? in the nested <embed> tag are correct (but the <embed> tag is deprecated and is disregarded by many browsers).

This seems to be a mistake in some sort of XSLT stylesheet, since "@flash-vars" appears to be an XPATH expression that is being output literally instead of resolved against some XML element.

Change History

Changed 7 years ago by ew2

  • suppressreporteremail unset
  • description modified (diff)

I tried the test module in Chrome, Opera, Firefox and IE.

  • In Chrome, both examples played correctly.
  • In Firefox 3.5 and Opera, The first example played, but the second displayed an error that it could not find the score.
  • In IE, neither displayed, but it could be something with Windows XP in my Virtualbox

Changed 7 years ago by ew2

  • owner changed from ew2 to maxwell
  • status changed from new to assigned

Changed 7 years ago by joe@…

The second example does not display in FF/Opera because of the tag corruption mentioned in the bug description.

The second example probably works in Chrome because Chrome disregards the outer <object> tag and instead uses the inner <embed> tag which has the correct FlashVars?.

In IE7 I get identical results to FF/Opera (first example works) so perhaps there is an issue on your side.

Changed 7 years ago by maxwell

  • status changed from assigned to awaitinginput

Joe, spot-on debugging of the problem. It is indeed outputting the literal string "@flash-vars" instead of that attribute's value. Sorry about that!

Ed, I tested the fix for this (using "{@flash-vars}" on that line instead of "@flash-vars") on maxdev and it appears to resolve the problem (at least on FF ... My IE doesn't have Flash 10). Is there a place I can commit this change?

Changed 7 years ago by ew2

  • status changed from awaitinginput to assigned
  • milestone changed from Ticket Triage to Express Edit or Reuse

Express Edit will be the next release, so it should go there. I'll move the ticket to the milestone.

Changed 7 years ago by ew2

  • milestone changed from Express Edit or Reuse to Hot Fixes

Moving to hot fixes

Changed 7 years ago by maxwell

(In [33495]) Making branch for ticket:10402 (flash vars problem). Refs ticket:10402

Changed 7 years ago by maxwell

  • status changed from assigned to testing

(In [33496]) Use actual attribute value instead of passing in literal string. Fixes ticket:10402.

Changed 7 years ago by ew2

  • status changed from testing to assigned

No changed behavior in any of the browsers. See test module at http://wakizashi.cnx.rice.edu:8080/content/m34203/latest/

Changed 7 years ago by maxwell

I don't see the fix applied at wakizashi:/usr/share/xml/cnxml/stylesheet/media.xsl

Changed 7 years ago by ew2

We discussed in Scrum and Ross thinks he missed installing it. He is correcting and I will retest.

Changed 7 years ago by ew2

Retested and had mixed results.

On Ubuntu

  • Module played correctly in all browsers (Chrome, FF and Opera)

On Windows - IE7

  • At first it did not load at all. I uninstalled and reinstalled the Flash Player (ver. 10). The module displayed, but would not play. Had Brian test on his Windows instance and he had the same problem.

On Windows - FF

  • Did not have flash installed, so I installed it (ver. 10). Had same problem as with IE. Brian reported same.

Test module: http://wakizashi.cnx.rice.edu:8080/content/m34203/latest/

Changed 7 years ago by ew2

  • status changed from assigned to testing

Tested it on an actual Windows PC. Once Flash 10 was installed it did play in IE 7. I think the problems Brian and I had must have been related to Virtualbox. Calling this fixed.

Changed 7 years ago by joe@…

Thanks for all the work on this bug. Can someone from Connexions please append a comment letting me know when this fix is deployed to the live site?

Changed 7 years ago by ew2

It will be deployed by EOD Friday.

Changed 7 years ago by ew2

  • status changed from testing to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.