Ticket #11438 (closed defect: fixed)

Opened 7 years ago

Last modified 5 years ago

collection keyword editing form should be half as wide

Reported by: maxwell Owned by: reedstrm
Priority: unprioritized Milestone: Sprint - 2011
Component: Collection Editing Version: Live
Severity: picky Keywords:
Cc: System Area: Authoring
Primary Skill: Plone
Site URL:
Suppress email to reporter: no

Description (last modified by maxwell) (diff)

As a visual clue that keywords should be on one line, we have the textarea used to edit them display with a CSS width of "50%", but this is only working for modules right now, and not collection (well, it works on collections during the creation process, but not afterwards (i.e. the "Metadata" tab post-creation)).

I couldn't figure out how to either put it in the widget, or add that CSS to the css_slot without it interfering with language_locale.css.

Attachments

collection_metadata.zip (2.6 KB) - added by zniper 6 years ago.
Updated the keywords textarea width (Products.RhaptosCollection?)

Change History

Changed 7 years ago by maxwell

  • description modified (diff)

Changed 6 years ago by maxwell

  • milestone changed from Ticket Triage to Sprint - 2011

Changed 6 years ago by zniper

Updated the keywords textarea width (Products.RhaptosCollection?)

Changed 6 years ago by zniper

Because there are only two places which editing collection keywords content: base_edit, collection_metadata and the width is already set on base_edit, so the changes is made just on the second target (collection_metadata)

Changes on collection_metadata.zip:

  • Add new css file named: collection_metadata.css. This one will hold all CSS customizations for collection_metadata.cpt
  • Update the collection_metadata.cpt, add stylesheet link to collection_metadata.css

Changed 6 years ago by reedstrm

  • owner changed from ew2 to reedstrm
  • status changed from new to assigned

Changed 6 years ago by reedstrm

  • status changed from assigned to testing

(In [35723]) znippers fix for width of collection keywords: fixes #11438

Changed 6 years ago by ew2

  • status changed from testing to closed
  • resolution set to fixed

Keyword field is now half as wide as it is on production. This is fixed.

Changed 6 years ago by maxwell

  • status changed from closed to accepted
  • resolution fixed deleted

Reopening for two reasons:

  1. The fix doesn't seem to be working on production, and shift-reloading doesn't help.
  2. Adding an entirely new CSS file for this one anomalous difference is a bit overkill, and I don't want to have another CSS file to keep track of. I think that the file could be deleted and that on collection_metadata.cpt, the lines reading:
     <link rel="stylesheet" href="/collection_metadata.css" type="text/css" title="Default" media="screen" 
           tal:attributes="href string:$portal_url/collection_metadata.css" />
    
    could be replaced with the following:
     <style type="text/css">
     #archetypes-fieldname-keywords textarea{
       width: 50%;
     }
     </style>
    
    (I just didn't know how to change from <style metal:fill-slot="css_slot"/> to <metal:css metal:fill-slot="css_slot"><style/><link/></metal:css> before zniper's fix.)

Changed 5 years ago by ew2

  • status changed from accepted to closed
  • resolution set to fixed

This is fixed and released. Closing.

Note: See TracTickets for help on using tickets.