Ticket #8336 (closed defect: fixed)

Opened 8 years ago

Last modified 6 years ago

Widen eip-help window slightly

Reported by: jenn Owned by: bnwest
Priority: medium Milestone: Sprint - 2011
Component: Documentation Version: Live
Severity: minor Keywords:
Cc: System Area: Authoring
Primary Skill: JavaScript
Site URL:
Suppress email to reporter: no

Description

In #8074, Kyle tidied the eip-help examples and code so that they once again fit inside the narrow popup window. But Manpreet did say that a small increase in width would be acceptable; and the main /eip-help/tags page really is quite cramped. There used to be three columns of tags and now there are four.

Could we add 50 or 100 pixels to the width of the popup, to give the columns some breathing space? See attached image comparing the window at 508 pixels (the current size) to one at 600 pixels.

Attachments

tag-list.png (31.6 KB) - added by jenn 8 years ago.
editInPlace.js.zip (80.5 KB) - added by bnwest 6 years ago.
the fix

Change History

Changed 8 years ago by jenn

Changed 6 years ago by maxwell

  • milestone changed from CNXML 0.6 - Phase 2 to Sprint - 2011

The code that pops up the eip-help windows (see the links when editing different elements of a module in Edit-In-Place) should be in src/Products.RhaptosModuleEditor/Products/RhaptosModuleEditor/skins/rhaptos_module_editor/eip/editInPlace.js (I think the openHelp function).

Changed 6 years ago by bnwest

  • owner set to bnwest
  • status changed from new to working

curent width is set here is EIP.js:

    var doOpen = window.open("/eip-help/" + name, "eip_help", 'scrollbars=yes,resizable=yes,height=400,width=500');

Changed 6 years ago by bnwest

  • status changed from working to testing

svn diff Index: editInPlace.js =================================================================== --- editInPlace.js (revision 35646) +++ editInPlace.js (working copy) @@ -11076,7 +11076,7 @@

function openHelp(name) {

- var doOpen = window.open("/eip-help/" + name, "eip_help", 'scrollbars=yes,resizable=yes,height=400,width=500'); + var doOpen = window.open("/eip-help/" + name, "eip_help", 'scrollbars=yes,resizable=yes,height=400,width=600');

doOpen.focus(); return false;

}

Changed 6 years ago by bnwest

the fix

Changed 6 years ago by ew2

(In [35753]) Checking in code from Sprint. Fixes #8336

Changed 6 years ago by ew2

  • status changed from testing to closed
  • resolution set to fixed

EIP help window is now wider. Tested in Firefox and Chrome.

Note: See TracTickets for help on using tickets.