Ticket #9440 (assigned defect)

Opened 8 years ago

Last modified 8 years ago

Need to add Siyavula logo to lens organizer entry on /lenses page

Reported by: je2 Owned by: jccooper
Priority: medium Milestone: Ticket Triage
Component: Lenses Version: Live
Severity: minor Keywords:
Cc: ew2, je2, kef System Area: Content Display
Primary Skill: Plone
Site URL: http://cnx.org/lenses
Suppress email to reporter: no


The Siyavula lens organizer is currently hard coded on the /lenses page, and at the moment there is no interface for adding a logo to a lens organizer object. We need to modify the hard coded entry to display the Siyavula logo (available from any of the subordinate lenses within the organizer) alongside the main entry (this should appear as it does with every other lens on the page).


actual-siyavula-case.png (47.7 KB) - added by jenn 8 years ago.
possible-future-case.png (49.7 KB) - added by jenn 8 years ago.

Change History

Changed 8 years ago by jccooper

  • cc ew2je2, kef added; ew2 removed
  • status changed from new to working

Looking at the code, we've already made provisions for this; if the 'siyavula' user is provided a user image, it will be used for the lens image for the Siyavula lens organizer. The only problem with this seems to be that we're doing some resizing on the image when it gets saved as the profile image, so it's not quite as big as we might like. I'll look at this, but it might be a good way to go that can happen right now.

Changed 8 years ago by jccooper

  • status changed from working to testing

(In [29206]) Change the max image size for profile images to 150x150, which matches the profile image help text's promise, and also matches the lens image size restrictions. This will allow siyavula to create their profile image at the same size as the lens images, so that when it appears at /lenses it will look right. Fix #9440

Changed 8 years ago by jccooper

  • cc ew2, je2 added; ew2je2 removed

When this rolls out, we can have whoever owns the 'siyavula' user add the profile image, and this'll be done. If we really need to I can create a script to do that, but I'd hope not to.

Changed 8 years ago by jccooper

This has no change to existing profile images, btw. See for example, 'dhj' and 'gabad'.

Changed 8 years ago by jccooper

See #9453 for rollout task of actually adding the image.

Changed 8 years ago by jenn

  • skills changed from Unspecified to Plone

This appears to work fine for the Siyavula logo, which is essentially horizontal; but we would run into a layout problem if they decided to upload something closer to square. See screenshots. In our current panic mode, this probably isn't a blocker, but it should definitely be addressed.

Changed 8 years ago by jenn

Changed 8 years ago by jenn

Changed 8 years ago by jccooper

Hm. Looks like for lens images we show on the listing page the thumbnail, which is max 50px tall. (The main image itself may be 150px tall.)

Since only Siyavula has the possibility of doing this, and at some point LensOrganizers? should probably get their own images with the same rules as Lenses, I don't think it's too bad. We could, however, get the same effect with a 'height=50px' in the HTML.

Changed 8 years ago by jenn

  • priority changed from unprioritized to medium
  • status changed from testing to assigned
  • type changed from task to defect
  • component changed from cnx.org Site Code to Lenses
  • milestone changed from Hot Fixes to Ticket Triage

Moving back into Triage so we can decide whether to make a new ticket or keep going with this one. The logo is in place on the live server, however.

Note: See TracTickets for help on using tickets.