Ticket #9995 (closed defect: fixed)

Opened 8 years ago

Last modified 7 years ago

"(1 ratings)" vs. "(1 rating)"

Reported by: maxwell Owned by: maxwell
Priority: unprioritized Milestone: Sprint - 2011
Component: Content Viewing Version: Live
Severity: picky Keywords:
Cc: System Area: Content Display
Primary Skill: Unspecified
Site URL:
Suppress email to reporter: no

Description

If a module has been rated once, we write "(1 ratings)" next to the stars. Would be better in singular.

Attachments

content_render.xsl (101.8 KB) - added by jared 7 years ago.
fixed by jaredadler
bottom_content_actions.pt (20.7 KB) - added by jared 7 years ago.
fixed by jaredadler

Change History

Changed 7 years ago by ew2

  • milestone changed from Ticket Triage to Sprint - 2011

Changed 7 years ago by ew2

2 places to fix this:

  • src/Products.RhaptosContent/Products/RhaptosContent/www/content_render.xsl
  • src/Products.RhaptosContent/Products/RhaptosContent/skins/rhaptos_content/bottom_content_actions.pt

Changed 7 years ago by jared

fixed by jaredadler

Changed 7 years ago by jared

fixed by jaredadler

Changed 7 years ago by bnwest

Partial fix is

svn diff src/Products.RhaptosContent/Products/RhaptosContent/www/content_render.xsl
Index: src/Products.RhaptosContent/Products/RhaptosContent/www/content_render.xsl
===================================================================
--- src/Products.RhaptosContent/Products/RhaptosContent/www/content_render.xsl	(revision 35646)
+++ src/Products.RhaptosContent/Products/RhaptosContent/www/content_render.xsl	(working copy)
@@ -1355,7 +1355,13 @@
                       <span id="content-render-rating-ratings">
                         <xsl:text>(</xsl:text>
                         <xsl:value-of select="/module/rating/@number_of_ratings"/>
-                        <xsl:text> ratings)</xsl:text>
+                        <xsl:if test="/module/rating/@number_of_ratings!=1">
+                          <xsl:text> ratings</xsl:text>
+                        </xsl:if>
+                        <xsl:if test="/module/rating/@number_of_ratings=1">
+                          <xsl:text> rating</xsl:text>
+                        </xsl:if>
+                        <xsl:text>)</xsl:text>
                       </span>
                       <span id="content-render-rating-login" style="display: none;">
                         <xsl:text>(Login required)</xsl:text>

Changed 7 years ago by ew2

(In [35749]) Checking in code from Sprint. Refs #9995

Changed 7 years ago by ew2

  • status changed from new to testing

(In [35750]) Checking in code from Sprint. Fixes #9995

Changed 7 years ago by ew2

  • status changed from testing to closed
  • resolution set to fixed

Tested single and multiple ratings on different modules. This is fixed.

Changed 7 years ago by maxwell

  • status changed from closed to accepted
  • resolution fixed deleted

I still see http://cnx.org/content/m10867/latest/ showing "1 ratings". Though I suppose this is low priority now that we will probably be obliterating ratings soon.

Changed 7 years ago by maxwell

  • status changed from accepted to closed
  • resolution set to fixed

Sorry, this required a shift reload.

Note: See TracTickets for help on using tickets.